Skip to content

Setup to allow sign/attest using both cosign v2 and v3#483

Draft
jdolitsky wants to merge 14 commits intochainguard-dev:mainfrom
jdolitsky:legacy-secant
Draft

Setup to allow sign/attest using both cosign v2 and v3#483
jdolitsky wants to merge 14 commits intochainguard-dev:mainfrom
jdolitsky:legacy-secant

Conversation

@jdolitsky
Copy link
Copy Markdown
Contributor

Add a "legacy" secant package, which reverts some of the changes in #471. This means we have 2 isolated secant packages that can be used by the provider to sign using either v2 or v3.

Not included here is a way to configure the provider to sign in one of 3 modes:

  • Just v3
  • Just v2 ("legacy")
  • Both

@jdolitsky jdolitsky requested a review from codysoyland March 23, 2026 21:36
@jdolitsky jdolitsky force-pushed the legacy-secant branch 2 times, most recently from a9d457a to f2c16f0 Compare March 23, 2026 22:00
Add a "legacy" secant package, which reverts some of the
changes in chainguard-dev#471. This means we have 2 isolated secant packages
that can be used by the provider to sign using either v2 or v3.

Not included here is a way to configure the provider to sign
in one of 3 modes:
- Just v3
- Just v2 ("legacy")
- Both

Signed-off-by: Josh Dolitsky <josh@dolit.ski>
@jdolitsky jdolitsky marked this pull request as draft March 23, 2026 22:44
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
@codysoyland
Copy link
Copy Markdown

I know this is still draft, but I did want to call out a couple of things:

  • We'll need to implement certificate caching like secant. I think we'll have to copy some code from cosign but sigstore-go offers BundleOptions.CertificateProvider which should help us with this.
  • I would really like to have some e2e tests for this. I see that secant doesn't have this currently but I think it's a good time to add it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants