Merged
Conversation
Collaborator
|
Hi @adrianthees, nice catch! Thanks for the info and patch! |
Contributor
Author
|
@Stamp9 I just tried it and it works as well. |
Collaborator
|
maybe we need to update the doc, PR welcome!
…On 2/6/26 13:17, Adrian Thees wrote:
*adrianthees* left a comment (chains-project/dirty-waters#248)
<#248 (comment)>
@Stamp9 <https://github.com/Stamp9> I just tried it and it works as well.
—
Reply to this email directly, view it on GitHub
<#248 (comment)>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGEGUSWHJID445RIZP4XRD4KSA53AVCNFSM6AAAAACUGXY4XOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTQNRQGEYDEOJYGY>.
You are receiving this because you are subscribed to this thread.Message ID:
***@***.***>
|
Contributor
Author
|
Like this #249 ? The fix in this patch would remedy that problem. |
Collaborator
|
@adrianthees thanks for the patch! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to run the tool installed via pypi it throws an error almost immediately:
Steps to reproduce:
pip install dirty-watersdirty-waters -p INRIA/spoon -pm mavenThis patch fixes that error.
Tested by applying the patch in an editable pypi install locally.