Skip to content

Conversation

@gdalle
Copy link
Collaborator

@gdalle gdalle commented Apr 5, 2025

Fixes #544

@codecov
Copy link

codecov bot commented Apr 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@willtebbutt
Copy link
Collaborator

Certainly, we need to get Mooncake running on the pre-release version of Julia. I'm just a little hesitant to permanently commit to running everything on pre-release, due to the extra CI load it will add (I'm assuming that it will add around 10-20 mins to a typical CI run, because we're already maxing out the number of parallel runners we can use).

What are your thoughts on this @gdalle ?

@gdalle
Copy link
Collaborator Author

gdalle commented Apr 10, 2025

Yeah it may not be worth it to always run tests on pre-release, especially when the pre-release is the same as the current one. You could detect this overlap with a script to cut the CI short though.
For a library such as Mooncake, which is very sensitive to Julia language internals, I think it does make sense to adapt as early as possible to new versions of the language though.
There are other things we can do to cut CI budget. For instance, add a switch so that draft PRs only run CI on Julia's latest release, and then once they are ready for review you add Julia LTS and pre-release? That's what I do for DI since I often run more CIs on drafts than on ready PRs

@willtebbutt
Copy link
Collaborator

willtebbutt commented Apr 10, 2025

Good points. What if we just ran the basic test suite on pre? I'm pretty sure that this will be sensitive to changes to the compiler internals, because this is the test suite which checks the 100ish test cases for rule-derivation, which necessarily involves IR transformation.

@timholy
Copy link

timholy commented Apr 18, 2025

@willtebbutt I've been doing quite a few updates to Julia 1.12, it's certainly a big set of changes: for many packages that delve into internals, I've found the changes are so breaking that I find it best to drop support for versions before 1.12. I recognize this might be undesirable for Mooncake.

One tip: if you're sensitive to line numbers, then CodeTracking.linetable_scopes may be of interest because it provides a consistent API for both pre- and post-Julia 1.12. I suspect you might be most interested in the variants that accept a CodeInfo although these don't currently get a mention in the docstring (I will fix that if you find it useful).

@willtebbutt
Copy link
Collaborator

Thanks for your thoughts @timholy -- sadly I really do need to maintain compatibility with 1.10 until we get a new LTS. I'll take a look at linetable_scopes!

@ChrisRackauckas
Copy link
Collaborator

RC1 is out so it would be good to enable pre.

@yebai yebai changed the title Add tests on pre-release version of Julia (currently 1.12) Add tests on Julia 1.12 Jul 15, 2025
@serenity4
Copy link
Collaborator

You can have a look at some of the fixes we did for Diffractor, e.g.:

@yebai
Copy link
Member

yebai commented Aug 27, 2025

Closed in favour of #714

@yebai yebai closed this Aug 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add tests on pre-release

6 participants