-
Notifications
You must be signed in to change notification settings - Fork 23
Add tests on Julia 1.12 #545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Certainly, we need to get Mooncake running on the pre-release version of Julia. I'm just a little hesitant to permanently commit to running everything on pre-release, due to the extra CI load it will add (I'm assuming that it will add around 10-20 mins to a typical CI run, because we're already maxing out the number of parallel runners we can use). What are your thoughts on this @gdalle ? |
|
Yeah it may not be worth it to always run tests on pre-release, especially when the pre-release is the same as the current one. You could detect this overlap with a script to cut the CI short though. |
|
Good points. What if we just ran the |
|
@willtebbutt I've been doing quite a few updates to Julia 1.12, it's certainly a big set of changes: for many packages that delve into internals, I've found the changes are so breaking that I find it best to drop support for versions before 1.12. I recognize this might be undesirable for Mooncake. One tip: if you're sensitive to line numbers, then |
|
Thanks for your thoughts @timholy -- sadly I really do need to maintain compatibility with 1.10 until we get a new LTS. I'll take a look at |
|
RC1 is out so it would be good to enable pre. |
Signed-off-by: Hong Ge <[email protected]>
Signed-off-by: Hong Ge <[email protected]>
Signed-off-by: Hong Ge <[email protected]>
|
You can have a look at some of the fixes we did for Diffractor, e.g.:
|
|
Closed in favour of #714 |
Fixes #544