Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"create_*_event" webservices - refs BT#17507 #3372

Open
wants to merge 23 commits into
base: 1.11.x
Choose a base branch
from

Conversation

sebastiendu
Copy link

No description provided.

Sébastien Ducoulombier added 17 commits July 11, 2020 18:30
Partialy simplified and already improved performance of these API functions:
 api_item_property_update
 api_max_sort_value
 CourseManager::create_course
 AddCourse::register_course
 CourseManager::fillCourse
 AddCourse::fill_db_course
 learnpath::add_lp
Fatal error: Uncaught PDOException: SQLSTATE[23000]: Integrity constraint violation: 1048 Column 'c_id' cannot be null
Course::prePersist calls Course::createSettings
@@ -282,12 +317,128 @@ class Course
*/
protected $room;

/**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Database changes are not allowed in 1.11.x

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Existing databases do not need to be updated, it will work as is.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Databases do not need to be altered to get this to work.
New databases will get new referential integrity checks (foreign keys). No table structural change.

@jmontoyaa
Copy link
Member

This PR refactors some core Chamilo code and create database changes, I don't think is suitable for a minor 1.11.x version.

@FlintCIBot
Copy link

Lint errors were found. A patch is also available.

Please see the report: https://flintci.io/repositories/1013/analyses/37790

This comment was posted by FlintCI. It can be disabled in the repository settings.

Sébastien Ducoulombier added 5 commits July 15, 2020 16:03
learning path item removal does not cascade-remove its learning path
AccessUrlRelCourse removal does not cascade-remove its course and url
CItemProperty removal does not cascade-remove its session
@FlintCIBot
Copy link

Lint errors were found. A patch is also available.

Please see the report: https://flintci.io/repositories/1013/analyses/39766

This comment was posted by FlintCI. It can be disabled in the repository settings.

jmontoyaa added a commit that referenced this pull request Sep 16, 2020
@ywarnier ywarnier added this to the 2.0 milestone Aug 9, 2021
@ywarnier ywarnier modified the milestones: 2.0, 1.11.28, 2.1 Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants