Plugin: Cleanup BBB recordings on course/session deletion - refs #3143 #6377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| } | ||
|
|
||
| // Remove BBB recordings linked to a specific course | ||
| private function removeBbbRecordingsForCourse(int $courseId): void |
There was a problem hiding this comment.
Function removeBbbRecordingsForCourse has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
| } | ||
|
|
||
| // Remove BBB recordings linked to a specific session | ||
| private function removeBbbRecordingsForSession(int $sessionId): void |
There was a problem hiding this comment.
Function removeBbbRecordingsForSession has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
|
Code Climate has analyzed commit e097083 and detected 2 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
|
I cannot really test it for now (we can still do that in beta) but the code looks good. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.