Fix: Flashes messages were not displayed for some actions - ref #6814 #6868
+85
−83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 8, 2025 13:34
Redirecting after deleting the course do not persist the flashes so they're not displayed. Passing a post request keep the flash messages
I suspected the flash messages to not work here either and I was right. I also removed the text-warning class because somehow with the get method it didn't work and the icon was still red. (And in yellow it's weird ?)
|
Flash messages in public/main/admin/course_list.php fixed here 4c0750e public/main/course_info/delete_course.php is not used with the new interface |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Issue:
#6814
The flash messages were not displayed on the
course_listpage. It was the case when you deleted a course or when you click on the category button.Problem:
When using
api_location(api_get_self());, the flash messages were somehow cleared.I tried using the PHP
header()function or attempted to manually write the session withsession_write_close(), but nothing worked.The only way to make it work was to remove this line, but doing so prevented the page from redirecting — leaving the parameters visible in the URL, which I’m not very comfortable with (especially the
sec_token).Resolution:
I changed the actions to use a form with the POST method, and now everything works correctly.
I also removed the
'text-warning'class because it didn’t work before, and now that it does apply, it looked a bit odd :Proof:
Capture vidéo du 2025-10-07 11-46-38.webm