Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setItem mutation param #28

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

benitogf
Copy link

@benitogf benitogf commented Jan 28, 2018

#27

@codecov
Copy link

codecov bot commented Jan 28, 2018

Codecov Report

Merging #28 into master will increase coverage by 6.74%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
+ Coverage   84.07%   90.81%   +6.74%     
==========================================
  Files           4        4              
  Lines         113       98      -15     
  Branches       36       25      -11     
==========================================
- Hits           95       89       -6     
+ Misses          8        2       -6     
+ Partials       10        7       -3
Impacted Files Coverage Δ
src/MockStorage.ts 100% <100%> (ø) ⬆️
src/index.ts 88.88% <100%> (+9.43%) ⬆️
build/rollup.config.js
rollup.config.js 100% <0%> (ø)
src/SimplePromiseQueue.ts 87.5% <0%> (+4.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4ee41d...51e14d9. Read the comment docs.

@championswimmer
Copy link
Owner

somehow there are a lot of conflicts, and I don't understand why. those are files untouched by you. probably new lines are not same on our operating systems

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants