Skip to content

Fix forecast displaying "[Object object]" instead of card sides #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chand1012 merged 5 commits into from
Jul 25, 2025
Merged

Fix forecast displaying "[Object object]" instead of card sides #2

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6bbfa32
Initial plan
Copilot Jul 25, 2025
d11ee2b
Initial analysis - identify forecast "[Object object]" issue
Copilot Jul 25, 2025
39643b4
Fix forecast display to show card sides instead of [Object object]
Copilot Jul 25, 2025
8403ba1
Fix TypeScript error: add Initiative type import and properly type ca…
Copilot Jul 25, 2025
b24a1db
Update forecast to display "growth" and "hostile" instead of "Visiona…
Copilot Jul 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion components/game-controller.tsx
View file
Open in desktop
Copy link
Copy Markdown
Owner

@chand1012 chand1012 Jul 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Type error in this file. Type error: Parameter 'card' implicitly has an 'any' type.

Please fix so that the vercel build succeeds.

Copy link
Copy Markdown
Author

Copilot AI Jul 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the TypeScript error by adding the Initiative type import and properly typing the card parameter in the map function. Also updated to use the existing isGrowthInitiative() helper function for better consistency. The Vercel build should now succeed. (commit 8403ba1)

Copy link
Copy Markdown
Owner

@chand1012 chand1012 Jul 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Names of forecasted cards should be "growth" and "hostile" not "visionary" and "insider".

Copy link
Copy Markdown
Author

Copilot AI Jul 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the forecast display to show "growth" and "hostile" card types instead of "Visionary" and "Insider" faction names. The forecast action now properly displays the card types themselves for better clarity. (commit b24a1db)

Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,10 @@ export function GameController({
message += `\n\n${result.target_name} is a ${result.actual_faction}`;
}
if (result.next_cards) {
message += `\n\nNext 3 cards: ${result.next_cards.join(", ")}`;
const cardTypes = result.next_cards.map(card =>
card.type === 'growth' ? 'Visionary' : 'Insider'
);
message += `\n\nNext 3 cards: ${cardTypes.join(", ")}`;
}
if (result.fired_role) {
message += `\n\nFired player was: ${result.fired_role}`;
Expand Down
Loading