-
Notifications
You must be signed in to change notification settings - Fork 0
Fix forecast displaying "[Object object]" instead of card sides #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
6bbfa32
Initial plan
Copilot d11ee2b
Initial analysis - identify forecast "[Object object]" issue
Copilot 39643b4
Fix forecast display to show card sides instead of [Object object]
Copilot 8403ba1
Fix TypeScript error: add Initiative type import and properly type ca…
Copilot b24a1db
Update forecast to display "growth" and "hostile" instead of "Visiona…
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,7 +1,7 @@ | ||||||
| "use client"; | ||||||
|
|
||||||
| import { useState, useEffect, useMemo, useCallback, useRef } from "react"; | ||||||
| import { GameState, Phase, Vote, isGrowthInitiative } from "@/lib/types"; | ||||||
| import { GameState, Phase, Vote, Initiative, isGrowthInitiative } from "@/lib/types"; | ||||||
| import { RoleAssignment } from "./role-assignment"; | ||||||
| import { COOActionPanel } from "./coo-action-panel"; | ||||||
| import { RulesModal } from "./rules-modal"; | ||||||
|
|
@@ -289,7 +289,10 @@ export function GameController({ | |||||
| message += `\n\n${result.target_name} is a ${result.actual_faction}`; | ||||||
| } | ||||||
| if (result.next_cards) { | ||||||
| message += `\n\nNext 3 cards: ${result.next_cards.join(", ")}`; | ||||||
| const cardTypes = result.next_cards.map((card: Initiative) => | ||||||
| isGrowthInitiative(card) ? 'growth' : 'hostile' | ||||||
|
||||||
| isGrowthInitiative(card) ? 'growth' : 'hostile' | |
| isGrowthInitiative(card) ? 'Visionary' : 'Insider' |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Type error in this file. Type error: Parameter 'card' implicitly has an 'any' type.
Please fix so that the vercel build succeeds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed the TypeScript error by adding the
Initiativetype import and properly typing thecardparameter in the map function. Also updated to use the existingisGrowthInitiative()helper function for better consistency. The Vercel build should now succeed. (commit 8403ba1)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Names of forecasted cards should be "growth" and "hostile" not "visionary" and "insider".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the forecast display to show "growth" and "hostile" card types instead of "Visionary" and "Insider" faction names. The forecast action now properly displays the card types themselves for better clarity. (commit b24a1db)