Fix flow errors #102
Open
Fix flow errors #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So merged "master" branch into "collab_2". After merging realized fonts were not working collaboratively when commented out due to compilation issues, for that separated the font code from "convertToCSSPTValue.js" to a new file "toClosestFontPtSize.js", which were causing compiling issues.
collab_2 branch was working nicely for collaboration.
2. FIX for Copy-Paste from external resource not working. This was related to incorrect merged code. 3. Windows build correction. 4. Enhancement: Image upload.
Copy-Paste & Image Upload
…n package.json. 2. Modified Readme.md file to use licit in other project.
…2 to run both servers together.
Upgrade jQuery & Webpack Devserver. Updated ReadMe.
…ng_renders_incorrectly Fix on increasing line spacing renders incorrectly in bullet or numbered list.
rename packge for npm publish
* 1. Issue fix :"TypeError: r is not a function" shows when run collab server * FIX: Errors with formidable when bundling collab server. * FIX: CORS error on image upload * Fixes: 1. Saving file not happening. 2. Not returning image on GET call. * Fix for IRAD-901: New collab server reusing base PM collab server to resolve collaboration inconsistencies. * 1. "saveimage" functionality in Upload image is moved from build_web_server to a separate server. * FIX: Unable to upload image with fully qualified Url * 1. Replaced chanzuckerberg/prosemirror-tables with ProseMirror/prosemirror-tables. 2. Fix : Licit editor tollbar poorly configured. 3. Modified README.md file to include commands to run image server for upload image. * New Image Server to deal image upload. Solved CORS issues. * 1. Licit Editor - Cannot reference image using fully qualified URL 2. Licit Editor - Editor allows changing font sizes when disabled 3. Licit Editor - Horizontal Line button is not greyed out when editor is disabled. * 1. Run Image server using bundle. 2. Use cors package instead of our own cors handling in image server where express is used. * Flow type checker in Collab & Image server. * Do type checking only in development mode. Co-authored-by: Ashfaq Shamsudeen <[email protected]> Co-authored-by: arathy <[email protected]> Co-authored-by: seybi.ea <[email protected]>
…ave been changed.
…nto fix_flow_errors
…bpack config to source, so that package could load fine with other application as well. Depends on exports-loader. 2. To delete the tarball file updated package with the new name. 3. Updated README to include scripts to load jQuery first so that MathQuill loads fine.
a. Changed the packed licit file name licit-0.0.1.tgz to modusoperandi-licit-0.0.2-0.tgz
b. Changed the package name in import { Licit } from 'licit'; to import { Licit } from "@modusoperandi/licit";
2. FIX: If we didn't specify the onChange or onReady event handlers, then the editor gives a run time error (err: noop is not defined)
3. Changed uploadImage Promise to take care of these issues:
1. Even if an image upload finishes in 700ms, it will take 3s for resolving the promise.
2. If the image upload takes more than 3s, then the promise will be incorrectly resolved before completing the upload.
… latest PM core updates.
… latest PM core updates.
… latest PM core updates.
…nto fix_flow_errors
firmusoft
requested review from
fresh-prince-of-prosemirror,
hedgerwang and
velveret
as code owners
2.Fixed list menu item disable issue on selecting document using Ctr+A
2.included licit folder in flowconfig.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.