Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Changes to analytics names and timing #1051

Merged
merged 6 commits into from
Jul 23, 2024

Conversation

rainandbare
Copy link
Contributor

@rainandbare rainandbare commented Jul 23, 2024

Addresses issue #7299

Renames:

  • EXPLORER_CLIP to EXPLORER_CLIP_SELECTED
  • EXPLORER_VISUALIZATION_SETTINGS_BUTTON_CLICKED to EXPLORER_CLIP_CLICKED

Only Trigger when feature is toggled on:

  • EXPLORER_SHOW_LABELS
  • EXPLORER_CLIP_CLICKED
  • EXPLORER_GENE_VIEW_DISTRIBUTION
  • EXPLORER_COLORBY_GENE
  • EXPLORER_COLORBY_GENE_SET

Checklist before Merge

  • Once event updates are deployed to Staging ping @ainfeld to check analytics
  • Verify events are showing up in the Staging space in Plausible correctly

@rainandbare rainandbare marked this pull request as ready for review July 23, 2024 17:51
@tihuan tihuan added the stack label Jul 23, 2024
@tihuan
Copy link
Contributor

tihuan commented Jul 23, 2024

Wow so fast 🔥 You're amazing, @rainandbare !!

I added stack label to get an rdev 👍 !

@tihuan
Copy link
Contributor

tihuan commented Jul 23, 2024

@rainandbare we might need to uncomment // console.log("track", event, options); temporarily for @ainfeld to verify the events in rdev 🙏

Thank you!

Copy link
Contributor

@tihuan tihuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM 👏 ! Just need @ainfeld to verify the events in rdev now 🙏

Thanks all 🚀 !!

@ainfeld
Copy link
Contributor

ainfeld commented Jul 23, 2024

Thanks!! @rainandbare I tried clicking the base URL above but it's not working. What URL should I look at to test out the events?

@rainandbare
Copy link
Contributor Author

rainandbare commented Jul 23, 2024

Thanks!! @rainandbare I tried clicking the base URL above but it's not working. What URL should I look at to test out the events?

Yeah - I see that too! Let me see what I can do. ⏳

Should be working now! @ainfeld

@rainandbare rainandbare added stack and removed stack labels Jul 23, 2024
@rainandbare rainandbare enabled auto-merge (squash) July 23, 2024 19:51
@rainandbare rainandbare merged commit ec42d18 into main Jul 23, 2024
18 of 19 checks passed
@rainandbare rainandbare deleted the rainandbare/7299-analytics-turn-on-only branch July 23, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants