-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add survey banner to Explorer #1063
Conversation
…rg/single-cell-explorer into rainandbare/7314-add-banner
…rg/single-cell-explorer into rainandbare/7314-add-banner
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just one discussion regarding the module export strategy 💡 Thank you!!
@@ -0,0 +1,12 @@ | |||
import BottomBanner from "./BottomBanner"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
discussion: should we put BottomBanner.tsx
code in the index.tsx
file here as a named export to avoid double exports 😄 ?
e.g.,
export const BottomBanner = connect(
mapStateToProps,
mapDispatchToProps
)(_BottomBanner);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah - lets do that for now! I wanted to suggest a new structure for the index files and folders but that is a bigger discussion and requires a little more time! Thanks for the review!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good thank you so much 🚀 ! Yeah would love to learn more about it once the launch is done 👍
…rg/single-cell-explorer into rainandbare/7314-add-banner
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
…rg/single-cell-explorer into rainandbare/7314-add-banner
rdev --> https://valid-elk.dev-sc.dev.czi.team/d/super-cool-spatial.cxg/?spatial=true
Reason for Change
Changes
Bottom Banner Visible and Clickable
Testing steps
Checklist 🛎️