fix(table): prevent columns from shrinking to zero width#671
Open
taciturnaxolotl wants to merge 1 commit into
Open
fix(table): prevent columns from shrinking to zero width#671taciturnaxolotl wants to merge 1 commit into
taciturnaxolotl wants to merge 1 commit into
Conversation
When a sibling column has long unbreakable tokens, the shrink algorithm could allocate zero width to short columns, making headers and cell content invisible. This adds a minimum-width floor (horizontal padding + 1) and a two-pass shrink strategy: first respecting the floor, then falling back to unreserved shrinking only when the width budget is impossible. Fixes: charmbracelet/glow#941 💘 Generated with Crush Assisted-by: DeepSeek V4 Pro via Crush <crush@charm.land>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
xPadding + max(min, 1)) so columns never collapse to invisibleWidth(1))Fixes: charmbracelet/glow#941
Test plan
💘 Generated with Crush
Assisted-by: DeepSeek V4 Pro via Crush crush@charm.land