fix: Unwanted white gap between bar border and bar fill (chartjs#12094) #12117
+82
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you also add a test for this? |
… - Added tests in element.bar.tests.js to verify pixel snapping fix
|
Hi, I added tests for the pixel snapping fix in element.bar.tests.js. Verifies that bars with a thick borderWidth do not produce white gaps. Verifies that borderRadius is handled correctly without creating gaps. The original change in element.bar.js remains the same; these tests just ensure the fix is covered automatically. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
inflateRectfunction in element.bar.jsRelated issue