better hsla regex to support float Hue #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etimberg
approved these changes
May 31, 2017
simonbrunel
requested changes
Jun 10, 2017
There was a problem hiding this comment.
I'm not sure this patch is working correctly, it seems that the fix in Qix-/color-string#19 is more complete (e.g. parseFloat instead of parseInt in var h = ((parseFloat(match[1]) % 360) + 360) % 360, which is missing here)? It also fix HWB and contains unit tests.
It may be better to resync this repo with the original one (git rebase)?
|
Resync then. Seems like your fork is very old. I just took a one improvement that was needed for my job. |
simonbrunel
force-pushed
the
master
branch
2 times, most recently
from
2147c1f to
9c077e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.