feat: stop saving txt_raw #6713
Merged
+7
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
link2xt
force-pushed
the
link2xt/edit-msg-txt-raw
branch
from
449a70d to
dddd94e
Compare
r10s
approved these changes
Mar 29, 2025
There was a problem hiding this comment.
code lgtm, maybe add a comment to table creation that txt_raw is no longer used, and only emptied for tombstones (which can be removed as well after some time)
this PR also breaks the "trick" to get to the actually send text when the bubble shows an error messages (this "See 'Info' for more details" could be used to read the message).
however, this always was a poor workaround, and by group consistency and by key-based-contacts, that anyway should become a very rare situation in the future.
"officially", the error message says nowhere that the text is in the info
It is redundant now that we have HTML view for long messages and is not updated when the message is edited.
link2xt
force-pushed
the
link2xt/edit-msg-txt-raw
branch
from
dddd94e to
3cbbc71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is redundant now that we have HTML view for long messages and is not updated when the message is edited.