-
-
Notifications
You must be signed in to change notification settings - Fork 99
feat: Always allow non-DC reactions to create chats #6769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
thanks for the idea, however, at a first glance, the existing code seemms easier to read and understand. usually, on tries to avoid "mut" for that reason. as it is about is_reaction in classic path - maybe just set the condition there. that would also make the logic change easier to understand and to judge if there maybe was a reason for current logic |
Pull request was converted to draft
This also unifies conditions for creating chats for chatmail and non-chatmail with `ShowEmails::All`. As for DC reaction messages, they don't contain extra parts, so they mustn't create chats.
7284137
to
8e9c046
Compare
After re-reading the code, i think that the intention was initially to avoid creating chats for DC reactions, so i changed it in this direction. A little more code, but at least the motivation should be clear now, otherwise the code looks maybe not buggy, but inconsistent. |
Yes, alternatively, we can prevent all reactions from creating chats, anyway it's a corner case. At least this also would make the code consistent. |
There are only DC reactions, so checking if the reaction is from DC or not is not useful. |
IMU of https://www.rfc-editor.org/rfc/rfc9078.html, there may be other message parts, not containing |
This also unifies conditions for creating chats for chatmail and non-chatmail with
ShowEmails::All
. As for DC reaction messages, they don't contain extra parts, so they mustn'tcreate chats.
Trying to resolve #6767 (comment)