Remove "Accepted contacts" option for downloading emails #6807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…igin Contacts are created with IncomingUnknownTo origin instead of IncomingTo now even if the message is from a known contact. Removed IncomingTo, IncomingCc, OutgoingBcc, OutgoingCc, IncomingUnknownCc origins.
link2xt
force-pushed
the
link2xt/contact-origin
branch
from
a4c3d16 to
4b85dd8
Compare
Hocuri
reviewed
Apr 20, 2025
| Hidden = 0x8, | ||
|
|
||
| /// From: of incoming messages of unknown sender | ||
| IncomingUnknownFrom = 0x10, | ||
|
|
||
| /// Cc: of incoming messages of unknown sender | ||
| IncomingUnknownCc = 0x20, | ||
|
|
||
| /// To: of incoming messages of unknown sender | ||
| IncomingUnknownTo = 0x40, |
There was a problem hiding this comment.
This was the case before this PR already, but, for my understanding: The order here determines which authnames are used, i.e. "better" origins overwrite the names of "worse" origins, with an exception that IncomingUnknownFrom may overwrite any other authname. (The origin also determines that contacts with at least IncomingReplyTo origin are shown in the contact list.)
I find the order super weird:
- IncomingUnknownFrom has the lowest priority of all. I would expect it to have a high priority, because this is obviously the name that comes directly from this contact.
- I would expect IncomingUnkwnownTo to have a lower priority, because it's a "gossiped" name - the displayname was in the "To" header in a message coming from some other contact.
- Same for IncomingReplyTo, because it's not guaranteed that this message actually came from the contact who controls the IncomingReplyTo address.
Is there something I'm missing?
In any case, I'm not saying we have to change this now, can come after multi-transport.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also misc contact origin simplifications because fine-grained contact origins were not really used. See commit messages.
Past member commit still needs a test.