Remove "Accepted contacts" option for downloading emails - #6807
Conversation
a4c3d16 to
4b85dd8
Compare
| IncomingUnknownCc = 0x20, | ||
|
|
||
| /// To: of incoming messages of unknown sender | ||
| IncomingUnknownTo = 0x40, |
There was a problem hiding this comment.
This was the case before this PR already, but, for my understanding: The order here determines which authnames are used, i.e. "better" origins overwrite the names of "worse" origins, with an exception that IncomingUnknownFrom may overwrite any other authname. (The origin also determines that contacts with at least IncomingReplyTo origin are shown in the contact list.)
I find the order super weird:
- IncomingUnknownFrom has the lowest priority of all. I would expect it to have a high priority, because this is obviously the name that comes directly from this contact.
- I would expect IncomingUnkwnownTo to have a lower priority, because it's a "gossiped" name - the displayname was in the "To" header in a message coming from some other contact.
- Same for IncomingReplyTo, because it's not guaranteed that this message actually came from the contact who controls the IncomingReplyTo address.
Is there something I'm missing?
In any case, I'm not saying we have to change this now, can come after multi-transport.
…igin Contacts are created with IncomingUnknownTo origin instead of IncomingTo now even if the message is from a known contact. Removed IncomingTo, IncomingCc, OutgoingBcc, OutgoingCc, IncomingUnknownCc origins.
4b85dd8 to
bce13b3
Compare
|
Closing stale PR. As a note, we likely want to discourage setting this value to anything that is not default "all": #7400 |
This comment was marked as duplicate.
This comment was marked as duplicate.
3 participants
Also misc contact origin simplifications because fine-grained contact origins were not really used. See commit messages.
Past member commit still needs a test.