fix: Don't unblock chat on possibly wrongly assigned outgoing encrypted 1:1 message #7079
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed 1:1 message For encrypted 1:1 messages we don't check the recipient fingerprint currently, so check that we don't have multiple key-contacts with the given recipient address.
iequidoo
commented
Aug 5, 2025
| @@ -3869,7 +3885,7 @@ async fn lookup_key_contact_by_fingerprint( | |||
| .sql | |||
| .query_row_optional( | |||
| "SELECT id FROM contacts | |||
| WHERE fingerprint=? AND fingerprint!=''", | |||
There was a problem hiding this comment.
There's already a check above
|
I have no idea how to improve this. If we have multiple key-contacts with the given address, we need to assign the message to one of them and we now prefer to choose accepted contacts. But anyway we may select a blocked contact, in this case assigning the message, but not unblocking the chat, looks like a lesser harm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably needs a test.