Skip to content

fix(auth): preserve legacy browser login - #2120

Merged
hmans merged 3 commits into
mainfrom
hmans/fix-browser-session-login
Aug 26, 2026
Merged

hmans merged 3 commits into
mainfrom
hmans/fix-browser-session-login

Conversation

@hmans

@hmans hmans commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Summary

  • accept same-origin legacy browser login requests that do not yet send the browser-auth mode header
  • force accepted legacy browser routes to create only the HttpOnly cookie session
  • keep form, cross-origin, and explicit non-cookie browser-mode requests rejected

Verification

  • mise test-cli --run TestAuthRoutes_BrowserLogin
  • mise x -- go test ./cli/internal/http_server -run 'TestAuthRoutes_BrowserLogin(DoesNotIssueBearerCredentials|RejectsCrossSiteAndFormRequests|AcceptsLegacySameOriginRequest)$' -count=1

@hmans
hmans merged commit 65f929b into main Aug 26, 2026
31 of 32 checks passed
@hmans
hmans deleted the hmans/fix-browser-session-login branch August 26, 2026 14:43
hmans added a commit that referenced this pull request Aug 26, 2026
…-v56

* origin/main:
  fix(dev): clean up archived workspace processes (#2121)
  fix(auth): preserve legacy browser login (#2120)
hmans added a commit that referenced this pull request Aug 27, 2026
…eviews

* origin/main: (405 commits)
  feat(authz): add interaction-scoped message reads (#2114)
  fix(auth): allow configured browser origin aliases (#2123)
  docs(agents): simplify instructions for ASD-STE100 (#2122)
  fix(dev): clean up archived workspace processes (#2121)
  fix(auth): preserve legacy browser login (#2120)
  docs: tighten local development guide (#2118)
  fix(auth)!: keep active users signed in (#2102)
  fix(notifications): avoid authorization fence events (#2115)
  feat(notifications): add scoped policy matrix (#2111)
  fix(api)!: prevent bots from starting DMs (#2113)
  feat(rbac)!: require message.read for channel content (#2100)
  feat(frontend): show inline message state markers (#2110)
  feat(frontend): refine room and thread dialogs (#2106)
  fix(realtime): defer retained timeline hydration (#2109)
  feat(frontend): submit dialog actions with Enter (#2107)
  feat(frontend): open created threads automatically (#2108)
  feat(frontend): show server re-login status (#2105)
  feat(frontend): frame preference forms (#2104)
  feat(frontend): add composer formatting shortcuts (#2103)
  feat(frontend): restructure settings and preferences (#2097)
  ...

# Conflicts:
#	AGENTS.md
#	apps/frontend/src/lib/api-client-tests/linkPreviews.spec.ts
#	apps/frontend/src/lib/api-client/linkPreviews.ts
#	apps/frontend/src/lib/components/composer/MessageComposer.svelte
#	cli/internal/connectapi/api_test.go
#	cli/internal/core/core.go
#	cli/internal/core/linkpreview/fetcher.go
#	cli/internal/core/linkpreview/fetcher_test.go
#	cli/internal/pb/chatto/api/v1/link_previews.pb.go
#	docs/ARCHITECTURE.md
#	docs/fdr/FDR-009-link-previews.md
#	packages/api-types/src/chatto/api/v1/link_previews_pb.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant