Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added param for navTitle to be used in the menu of the docs #1072

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

Dgiordano33
Copy link
Contributor

Affected Components

  • Content & Marketing
  • Pricing
  • Test
  • [ X ] Docs
  • Learn
  • Other

Pre-Requisites

  • [ X ] Code is linted (npm run lint)

Notes for the Reviewer

The title of the documentation page is now separated from the title that appears on the sidebar menu. Each documentation page now has a param called navTitle that dictates the title of the sidebar menu.

New Dependency Submission

Screenshots

image

You can see that the title on the sidebarnav of this page is different than the page H1.

Copy link

vercel bot commented Sep 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
checklyhq-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 19, 2024 7:25pm

@Dgiordano33 Dgiordano33 requested review from MariadeAnton and removed request for tnolet September 19, 2024 19:25
Copy link
Contributor

@MariadeAnton MariadeAnton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Nice, thank you so much, Dan!

@Dgiordano33 Dgiordano33 merged commit cf4cb5e into main Sep 19, 2024
6 checks passed
@Dgiordano33 Dgiordano33 deleted the feature-dg-navmenu-title branch September 19, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants