Use only FINAL results in the single check analysis

[jan-osch]

• In a follow-up PR implement the degraded and retries analysis

[coderabbitai]

Walkthrough

This pull request updates the error clustering and summary-generation logic. The findErrorClustersForChecks function now accepts an options object that includes a new optional resultType parameter, in addition to the existing optional interval. The query logic in the database module and its invocation in the check-summary command have been modified to filter for "FINAL" results. Additionally, the text label in the Slack block output is updated from "Summary:" to "Failures Summary:".

Changes

File(s)	Change Summary
src/db/error-cluster.ts	Updated findErrorClustersForChecks to accept an options object (interval and new resultType).
src/slackbot/commands/check-summary.ts	Updated findErrorClustersForChecks call to use the new options object and added filtering to use only results with resultType equal to "FINAL".
src/slackbot/blocks/newCheckSummaryBlock.ts	Modified the text in generateCheckSummaryBlock to change the label from "Summary:" to "Failures Summary:".
src/slackbot/accountSummaryCommandHandler.ts	Updated findErrorClustersForChecks call to pass interval wrapped in an options object.

Possibly related PRs

• @aluedeke/improve account summary #76: The changes in the main PR are related to the modifications made to the findErrorClustersForChecks function, as both PRs involve updates to its parameters and usage, specifically regarding the handling of the resultType property.
• Improve check formatting for summary. Add extra context #79: The changes in the main PR, specifically the modifications to the findErrorClustersForChecks function, are directly related to the updates in the check-summary.ts file where the function is called with the new parameter structure.
• Fix numerous bugs in the check-summary #83: The changes in the main PR, specifically the modifications to the findErrorClustersForChecks function to accept a new parameter structure, are directly related to the updates in the retrieved PR where the same function is called with the new parameter format, including the resultType property.

Suggested reviewers

• aluedeke
• tnolet

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 26f0bd8 and 8db29af.

📒 Files selected for processing (1)

• src/slackbot/accountSummaryCommandHandler.ts (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: build

🔇 Additional comments (1)

src/slackbot/accountSummaryCommandHandler.ts (1)

45-48:

✅ Verification successful

Function parameter change aligns with PR objective.

The change from passing interval directly to wrapping it in an object { interval } aligns with the PR objective of using only FINAL results in single check analysis. This modification matches the updated function signature in the error-cluster module.

---

🏁 Script executed:

#!/bin/bash
# Check if all calls to findErrorClustersForChecks have been updated to the new signature
rg -A 3 "findErrorClustersForChecks\(" --glob "*.ts"

Length of output: 891

---

Review Verification: Parameter Update Confirmed

The changes—from passing interval directly to wrapping it in an object ({ interval })—have been verified across the codebase. In particular:

• src/slackbot/accountSummaryCommandHandler.ts now calls:

  const errorPatterns = await findErrorClustersForChecks(
    accountSummary.checks.map((c) => c.id),
    { interval },
  );

  which aligns with the updated function signature in the error-cluster module.

• An additional call in src/slackbot/commands/check-summary.ts uses a similar pattern (with an extra option { interval, resultType: "FINAL" }), further confirming consistency with the PR objective.

This parameter change aligns with using only FINAL results in the single check analysis and matches the updated function signature as defined in src/db/error-cluster.ts.

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.