feat: enhance payment details structure with new consent and item subypes #189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
david-ruiz-cko
approved these changes
Dec 3, 2025
armando-rodriguez-cko
deleted the
feature/enhance-payment-details-structure-with-new-consent-and-item-subtypes
branch
david-ruiz-cko
pushed a commit
that referenced
this pull request
Dec 11, 2025
armando-rodriguez-cko
added a commit
that referenced
this pull request
Dec 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several updates to the
payments.gofile, mainly focusing on improving type definitions, updating product and affiliate data structures, and cleaning up unused code. The most important changes are grouped below by theme.Type Definitions and Refactoring:
ItemTypetype and its associated constants (DigitalIT,DiscountIT,PhysicalIT). TheProduct.Typefield now uses a plainstringinstead ofItemType. [1] [2]ItemSubTypeconstants for clarity by removing theISTsuffix and using more conventional names (e.g.,NFTinstead ofNftIST).Affiliate Data Fields:
AffiliateIdandAffiliateUrlfields to the main payment request struct, enabling tracking of affiliate information with payment requests.AffiliateIdandAffiliateUrlfields from theCardPaymentRequeststruct, consolidating affiliate data at a higher level.Payment Details Consent:
StorePaymentDetailsTypeconstantCollectConsent, allowing for explicit handling of user consent when storing payment details.