Skip to content

Conversation

@armando-rodriguez-cko
Copy link
Contributor

This pull request introduces a new strongly-typed enumeration for product item types in the payments package, replacing the previous use of plain strings. This improves type safety and code clarity when working with product types.

Type safety improvements:

  • Added a new ItemType type and defined constants for digital, discount, and physical item types in payments.go.
  • Updated the Product struct to use the new ItemType type for the Type field instead of a plain string in payments.go.

@armando-rodriguez-cko armando-rodriguez-cko requested a review from a team December 4, 2025 17:05
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 4, 2025

@david-ruiz-cko david-ruiz-cko merged commit 585c731 into master Dec 4, 2025
2 of 4 checks passed
@david-ruiz-cko david-ruiz-cko deleted the feature/restore-ItemType-constants-and-update-Product-struct branch December 4, 2025 17:30
david-ruiz-cko pushed a commit that referenced this pull request Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants