feat: add new endpoint payment setups support #191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armando-rodriguez-cko
changed the title
armando-rodriguez-cko
force-pushed
the
feature/new-endpoint-payment-setups
branch
3 times, most recently
from
6a37f54 to
0ee48fb
Compare
armando-rodriguez-cko
force-pushed
the
feature/new-endpoint-payment-setups
branch
from
0ee48fb to
d501b26
Compare
|
armando-rodriguez-cko
approved these changes
Dec 16, 2025
madrazo-lucas-cko
approved these changes
Dec 16, 2025
armando-rodriguez-cko
deleted the
feature/new-endpoint-payment-setups
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new
payments/setupspackage to support Payment Setup operations, including creating, updating, retrieving, and confirming payment setups. It also integrates the new Payment Setups client into both the ABC and NAS API entry points and adds comprehensive unit tests for the new functionality. Additionally, it improves type safety in the payments domain and updates CI workflows to use newer GitHub Actions versions.Payment Setups feature:
payments/setupspackage with aClientthat supports creating, updating, retrieving, and confirming payment setups via the API. This includes methods for each operation, with appropriate authorization handling and documentation.payments/setups/client_test.goto cover all Payment Setups client methods, including authorization failures and success cases.SDK API integration:
PaymentSetupsclient in both theabc/checkout_api.goandnas/checkout_api.goAPI entry points, making payment setup functionality available in both API variants. [1] [2] [3] [4] [5] [6]Type safety improvements:
Ticket.IssueDate,Passenger.DateOfBirth, andFlight.DepartureDatefields inpayments/payments.gofromstringto*time.Timeto improve type safety and better represent date/time values. [1] [2] [3]CI/CD workflow updates:
actions/checkoutandactions/setup-goin all workflow files to use the latest major versions, improving security and compatibility. [1] [2] [3]