APIShortDate type for yyyy-MM-dd date formats

[armando-rodriguez-cko]

This pull request introduces a new custom date type, APIShortDate, to enforce strict handling of API date fields in the yyyy-MM-dd format. The main changes include implementing this type, updating relevant data structures to use it, and adding comprehensive tests to ensure correct parsing and formatting.

API Date Handling Improvements:

• Added a new APIShortDate type in common/apishortdate.go that supports only the yyyy-MM-dd format, with custom JSON marshal/unmarshal logic to reject other date/time formats.
• Updated the InstrumentData struct's DateOfSignature field in instruments/nas/instuments.go to use *common.APIShortDate instead of *time.Time, ensuring only valid short dates are accepted.

Test Coverage Enhancements:

• Added a new test suite in test/apishortdate_test.go covering valid/invalid formats, round-trip marshalling, and edge cases for APIShortDate.
• Updated test helpers and integration tests to use and validate the new APIShortDate type, including changes in instruments/nas/client_test.go and test/instruments_test.go. [1] [2] [3]

Codebase Cleanup:

• Removed unnecessary imports of time in instruments/nas/instuments.go since date handling is now abstracted by APIShortDate.
• Minor import reordering for clarity in test files.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud