Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: duplicate key removed, fixed peer dependency #34

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: duplicate key removed, fixed peer dependency #34

wants to merge 3 commits into from

Conversation

kjappelbaum
Copy link

  • homepage key was duplicated
  • was unable to resolve dependency tree
  • bumped dependencies

fix: duplicate key removed, fixed peer dependency
98af681 
- homepage key was duplicated
- was unable to resolve dependency tree
maasencioh
maasencioh approved these changes Apr 6, 2021
View reviewed changes
Copy link
Member

@maasencioh maasencioh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, did you try the output of these changes? Just to be sure that everything builds normally

@stropitek
Copy link
Contributor

We need to adapt tailwind and postcss config files for tailwind v2. I will push some changes soon related to that.

Once I've done so @kjappelbaum could you test the change by building a new project? Let us know if you need any help on how to do so without publishing the package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maasencioh maasencioh maasencioh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kjappelbaum @stropitek @maasencioh