Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip lost+found directory #795

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

debu99
Copy link

@debu99 debu99 commented May 1, 2024

Description

Skip lost+found subdirectory in the plugin when mount volume for the plugin directory

Related to issue #(issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@pieroit
Copy link
Member

pieroit commented May 5, 2024

When does this folder appear? Why is it a problem?
Thanks @debu99

@debu99
Copy link
Author

debu99 commented May 9, 2024

When does this folder appear? Why is it a problem? Thanks @debu99

Hi, when you mount a volume/disk as permanment storage for plugin, the OS will auto generate it, if not exclude, there will be error popup in the log [2024-05-09 07:51:17.902] ERROR cat.mad_hatter.mad_hatter.MadHatter.load_plugin::127 "cat/plugins/lost+found/ does not contain any python files. Cannot create Plugin."

@pieroit
Copy link
Member

pieroit commented May 19, 2024

Hi @debu99, better to not hardcode folder names relative to operating systems.

What do you think about turning the ERROR in a WARNING here?

Exception is already well handled, because the plugin is not created and the folder is skipped.

Thanks a lot!

@vl-kp
Copy link

vl-kp commented May 22, 2024

Hi @debu99, better to not hardcode folder names relative to operating systems.

What do you think about turning the ERROR in a WARNING here?

Exception is already well handled, because the plugin is not created and the folder is skipped.

Thanks a lot!

sure, i am fine with it

@@ -102,11 +102,17 @@ def find_plugins(self):
log.info("ACTIVE PLUGINS:")
log.info(self.active_plugins)

# Directories to skip
skip_directories = ['lost+found']
Copy link

@matteocacciola matteocacciola Oct 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about skipping __pycache__ as well? what about naming the variable as skip_folder, just for naming consistency?

@valentimarco valentimarco added the enhancement New feature or request label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants