Skip to content

Fix empty branches_to_generate #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mrhallak wants to merge 3 commits into from
Closed

Fix empty branches_to_generate #64

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a0ba73b
Merge pull request #71 from chocoapp/master
siklosid Jul 23, 2023
0a3b98a
Fix issues for pre-commit
mrhallak Nov 13, 2025
55e6610
Merge branch 'master' into hotfix/fix-issues-with-pre-commit
mrhallak Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions dagger/utilities/module.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ def __init__(self, path_to_config, target_dir, jinja_parameters=None):
f"{path.join(self._directory, task)}.yaml"
)

self._branches_to_generate = config["branches_to_generate"]
self._branches_to_generate = config.get("branches_to_generate", {})
self._override_parameters = config.get("override_parameters", {})
self._default_parameters = config.get("default_parameters", {})
self._jinja_parameters = jinja_parameters or {}
Expand Down Expand Up @@ -96,13 +96,17 @@ def dump_yaml(yaml_str, yaml_path):
)

def generate_task_configs(self):
if not self._branches_to_generate:
_logger.warning("No branches to generate found in config")
return

for branch_name, attrs in self._branches_to_generate.items():
attrs = {} if attrs is None else attrs
_logger.info(f"Generating tasks for branch {branch_name}")
template_parameters = {}
template_parameters.update(self._default_parameters or {})
template_parameters.update(attrs)
template_parameters['branch_name'] = branch_name
template_parameters["branch_name"] = branch_name
template_parameters.update(self._jinja_parameters)

for task, task_yaml in self._tasks.items():
Expand Down