Conversation
(maint) Finish the 3.0.0 release by merging master to develop
Update assembly signing conditions across project files to validate both that the CHOCOLATEY_OFFICIAL_KEY variable is set and that the key fileactually exists on disk. This prevents test failures when the variableis defined but points to a non-existent file path, and ensures that theassemblies are always signed.Key Changes:- Add file existence check to PropertyGroup conditions in relevant project files.Reason for the change:- Prevent test failures when signing key variable is set but file does not exist.- Improve build reliability by checking both variable and file existence.
…alidation (maint) Fix assembly not signed if environment key doesn't exist
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Merging master back to develop
Motivation and Context
Finalizing the release
Testing
N/A
Operating Systems Testing
N/A
Change Types Made
Change Checklist
Related Issue
N/A