Open
Conversation
Collaborator
|
These changes look good, but io needs a refactor since I merged the slice PR in first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be reviewed after #481 is merged
This PR refactors a bunch of logic so all the projection-related logic for
RotatedProjWriteris within RotatedProjWriter.cpp.As part of this PR, I factored out the common logic for writing the common header attributes present in the rotated projection outputs and the headers of projections, slices, and full field dumps. I have taken a lot of care to ensure that I don't introduce new headers.
Would it be ok if I add all the header attributes from projections, slices, and full field dumps to rotated projection dumps? For context, the attributes are the same for those 3 output types. (From a code perspective, it simplifies logic. Plus, I can't think of a compelling reason why we would want Rotated Projections to be different)
I did a lot of careful testing to make sure I didn't break anything (which took a surprising amount of time)