Some cleanup of unused build-time configuration options#485
Open
mabruzzo wants to merge 15 commits intocholla-hydro:devfrom
Open
Some cleanup of unused build-time configuration options#485mabruzzo wants to merge 15 commits intocholla-hydro:devfrom
mabruzzo wants to merge 15 commits intocholla-hydro:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A followup to #483
Back when I wrote #483, I used
grepand regex commands to extract every single macro referenced by the builds directory. 8 of them were spurious options that never get used for anything (in just about every case they showed up in commented lines). This PR cleans up these unused options