Simple housekeeping for Parameters#496
Merged
evaneschneider merged 5 commits intocholla-hydro:devfrom Apr 15, 2026
Merged
Conversation
Basically, I had totally forgotten to remove these parameters
mabruzzo
commented
Mar 30, 2026
Comment on lines
+189
to
+194
| * \note | ||
| * Before removing a parameter from this type, check if that parameter is parsed | ||
| * within \ref Old_Style_Parse_Param. PRs 489, 493, 494, and 495 seek to remove all | ||
| * of the parameters from that function. Thus, you may want to merge in the work from | ||
| * the branch where the parameter parsing logic has been moved **BEFORE** you start to | ||
| * relocate logic. (Otherwise, you are going to encounter some merge conflicts) |
Collaborator
Author
There was a problem hiding this comment.
Yes, I know that the enumerated PRs are all less than 496. After creating this PR, I went and re-ordered the commits. The new order of review is 496 (first) -> 489 -> 493 -> 494 -> 495 (last).
Aside: In each of the enumerated PRs, I made a point of updating this comment (e.g. #489 drops the mention of PR 489, #493 drops the reference to 493, #494 drops the reference to 494, and the remainder of the comment is dropped in #495)
Collaborator
Author
|
@evaneschneider, of all the pending PRs, this is probably the one I would like to see merged first |
evaneschneider
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This does some basic house-keeping for the
Parametersstruct.Essentially, this PR:
Parameters(explaining how its being phased out)Parse_ParamsParse_ParamsParametersn_hydro,n_particle,n_projection, ...Parametersstruct each time I started directly reading these values frompmapwithin the constructor ofWriterManager.