H5 Attributes Now Prefer Little Endian#501
Open
mabruzzo wants to merge 23 commits intocholla-hydro:devfrom
Open
H5 Attributes Now Prefer Little Endian#501mabruzzo wants to merge 23 commits intocholla-hydro:devfrom
mabruzzo wants to merge 23 commits intocholla-hydro:devfrom
Conversation
``AttrRecorderInterface`` is an abstract class that defines a generic interface that different file backends may implement in order to save file-header-attributes. - subclasses are expected to implement the pure virtual functions - the existing ``H5AttrRecorder`` class has been tweaked so that it is now a subclass of ``AttrRecorderInterface`` ``Write_Header_`` is a local function that operates upon a reference to ``AttrRecorderInterface`` (in practice, callers need to pass an instance of a concrete subclass). The implementation was extracted from ``Grid3D::Write_Header_HDF5``
It is now known as ``always_false`` (I have modified the docstring to further clarify its purpose)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be reviewed after #486 has been merged
This is an extremely simple change