Skip to content

Commit

Permalink
msglist: Fix mark-as-read button icon color in dark mode
Browse files Browse the repository at this point in the history
After sweeping through the message-list screen to implement dark
theme (zulip#843), in late July, the Flutter framework merged
flutter/flutter#143501, in early August. This made it so our
`foregroundColor` no longer controlled the icon color, as promised
in the dartdocs of `foregroundColor` and `iconColor`.

I opened an issue for Flutter about the inconsistency with the doc:
  flutter/flutter#154644
and sent a PR to resolve it, by updating the doc (which the author
of 143501 had said was the right fix):
  flutter/flutter#154646

Fixes: zulip#926
  • Loading branch information
chrisbobbe authored and gnprice committed Sep 9, 2024
1 parent 2dda626 commit 5dab0a6
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions lib/widgets/message_list.dart
Original file line number Diff line number Diff line change
Expand Up @@ -758,6 +758,7 @@ class _MarkAsReadWidgetState extends State<MarkAsReadWidget> {
// state is disabled, pressed, etc. We handle those states
// separately, via MarkAsReadAnimation.
foregroundColor: const WidgetStatePropertyAll(Colors.white),
iconColor: const WidgetStatePropertyAll(Colors.white),
backgroundColor: WidgetStatePropertyAll(messageListTheme.unreadMarker),
),
onPressed: _loading ? null : () => _handlePress(context),
Expand Down

0 comments on commit 5dab0a6

Please sign in to comment.