[ENH] New Embedding Function - VoyageAIEmbeddingFunction#1327
[ENH] New Embedding Function - VoyageAIEmbeddingFunction#1327ha-sante wants to merge 15 commits intochroma-core:mainfrom
Conversation
This adds embedding function support for voyageai.com. Documentation: - https://docs.voyageai.com/tutorials/
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
|
@ha-sante Would you be ok to make the texts -> input change? |
|
Thanks for the recall @HammadB - will resubmit the changes before tomorrow ending gmt. - Thanks |
|
@ha-sante, thank you so much for the hard work. With your permission, I'll do the following:
|
|
@tazarov You have my permission 👍 |
- Updated the EF to the latest API - Added a few more options - Tests
- Updated API key to be VOYAGE_API_KEY - Test cleanup
|
Related PR - #1871. I asked the OP to only merge the JS functionality |
|
merge it man, feature is more important than minor inconsistencies. atleast chroma dev branch should be have canary like releases. |
|
Hi , please merge, im having to write seperate utils for the same, and code is getting scattered. |
|
@nikhil-swamix, thank your patience and hard work. We are refactoring the EFs, and I'll get back to you within the week. |
thanks very much! your commitment to opensource is helping thousands. |
# Conflicts: # chromadb/utils/embedding_functions.py
|
@atroyn, this is rebased and tested, and the docs are updated. |
|
Our underlying impl has changed and so this PR is not landable as is. That being said - we'd still like to add this functionality and that is now tracked in this issue. |
Im really concerned, the way chroma is heading. so this guy's few hour effort for PR is now garbage. which would handicap lot of enthusiasts and scared from contributing. i have most utils seperately written just as inbuilt stuffs just break or show type error/mismatch with new versions. no offence just my perspective. regards. |
Description of changes
Summarize the changes made by this PR.
- Addition of VoyageAI to the list of embedding functions supported natively.
Test plan
How are these changes tested?
py test_voyage_ef.pyDocumentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?