[ENH] Add Embedding Function - Universal Sentence Encoder#1723
Closed
csbasil wants to merge 1 commit intochroma-core:mainfrom
Closed
[ENH] Add Embedding Function - Universal Sentence Encoder#1723csbasil wants to merge 1 commit intochroma-core:mainfrom
csbasil wants to merge 1 commit intochroma-core:mainfrom
Conversation
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
atroyn
suggested changes
Feb 23, 2024
Contributor
atroyn
left a comment
There was a problem hiding this comment.
The code looks correct, is there a corresponding documentation update?
https://github.com/chroma-core/docs/blob/main/docs/embeddings.md
Author
|
@atroyn I have created a PR for the same: chroma-core/docs#219 |
Author
7da9620 to
3d898ed
Compare
atroyn
approved these changes
Apr 3, 2024
Contributor
|
@csbasil happy to land this once requested changes are made to the docs: chroma-core/docs#219 |
Closed
4 tasks
Author
|
@atroyn I have made requested docs changes. Kindly have a look |
Contributor
|
Our underlying impl has changed and so this PR is not landable as is. That being said - we'd still like to add this functionality and that is now tracked in this issue. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Summarize the changes made by this PR.
Test plan
How are these changes tested?
pytestfor python