[ENH]: FastEmbed embedding function support#1986
[ENH]: FastEmbed embedding function support#1986Anush008 wants to merge 14 commits intochroma-core:mainfrom
Conversation
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
|
@Anush008, thanks for this. It looks good. Can I ask you to add a Docs PR—https://github.com/chroma-core/docs/pulls? I can add that, too. |
Will do. |
|
Associated docs PR: chroma-core/docs#233. |
tazarov
left a comment
There was a problem hiding this comment.
One tiny nit about batch size and threads
|
Hi @tazarov. Just bumping this PR, since there are a lot of them. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hello @tazarov. FYI, I've refactored the implementation into a separate file, as per the recent changes. |
|
Our underlying impl has changed and so this PR is not landable as is. That being said - we'd still like to add this functionality and that is now tracked in this issue. |
Description of changes
Test plan
Unit test has been set up.
Tests pass locally with
pytestfor python.Documentation Changes