[BUG] 1965 Split up embedding functions - Redux#2395
Merged
Conversation
This reverts commit 7da06e7.
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
atroyn
changed the title
atroyn
commented
Jun 21, 2024
| attr = getattr(module, attr_name) | ||
| if ( | ||
| isinstance(attr, type) | ||
| and isinstance(attr, EmbeddingFunction) |
Anush008
pushed a commit
to Anush008/chroma
that referenced
this pull request
Jun 27, 2024
## Description of changes The original attempt to split up the embedding functions failed because of python 3.9 and 3.10 incompatibilities with `issubtype`. Original PR here: chroma-core#2034 Failing tests here: https://github.com/chroma-core/chroma/actions/runs/9605053108/job/26491923410 The fix is changing `issubtype` to `isinstance`, which has the same functionality. ## Test plan Along with CI, tested locally with python 3.9 and 3.10 and confirmed passing. ## Documentation Changes N/A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
The original attempt to split up the embedding functions failed because of python 3.9 and 3.10 incompatibilities with
issubtype.Original PR here: #2034
Failing tests here: https://github.com/chroma-core/chroma/actions/runs/9605053108/job/26491923410
The fix is changing
issubtypetoisinstance, which has the same functionality.Test plan
Along with CI, tested locally with python 3.9 and 3.10 and confirmed passing.
Documentation Changes
N/A