Skip to content

[BUG]: Prevent hnsw cleanup if use_direct_hnsw is true #5933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 3, 2025
Merged

[BUG]: Prevent hnsw cleanup if use_direct_hnsw is true #5933

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rust/index/src/hnsw_provider.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ pub struct HnswIndexProvider {
// TODO(tanujnay112): This feature flag is a temporary measure to gate
// the hnsw loading from memory feature. Remove this after that feature
// stabilizes.
use_direct_hnsw: bool,
pub use_direct_hnsw: bool,
}

pub struct HnswIndexFlusher {
Expand Down
5 changes: 5 additions & 0 deletions rust/worker/src/execution/orchestration/compact.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -834,6 +834,11 @@ impl CompactionContext {
}

pub(crate) async fn cleanup(self) {
if self.hnsw_provider.use_direct_hnsw {
return;
}

// TODO(tanujnay112): Remove when use_direct_hnsw is fully deprecated
for hnsw_index_uuid in self.hnsw_index_uuids {
let _ = HnswIndexProvider::purge_one_id(
self.hnsw_provider.temporary_storage_path.as_path(),
Expand Down
Loading