Fix *_DAYS_FROM_YEAR_0 calculation
#1312
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
MIN_DAYS_FROM_YEAR_0andMAX_DAYS_FROM_YEAR_0constants are only used in tests.As described in #1048 there is something subtly wrong in the derivation of them. But I was not smart enough to put my finger on it 😄.
The formula was only correct if
MIN_YEARwas a leap year. I changed it to a correct formula that tries to be less smart, and tested it to be correct for all possible years.test_date_boundshelps to verifyNaiveDate::MINandNaiveDate::MAXare correct. I changed it a little to also report the last ordinal day inNaiveDate::MAX.Split out from #1048.