Skip to content

fix: Replace panic-prone unwrap() calls with proper error handling #1332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
doocho wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Replace panic-prone unwrap() calls with proper error handling #1332

doocho wants to merge 1 commit into from
+17 −7

Conversation

@doocho
Copy link

@doocho doocho commented Dec 29, 2025

  • identify.rs: Handle empty listen_addrs with if-let instead of unwrap()
  • spawn.rs: Propagate directory creation errors with ? operator
  • app.rs: Handle JSON encoding errors gracefully with logging

Closes: #768

PR author checklist

For all contributors

For external contributors

@doocho
fix: Replace panic-prone unwrap() calls with proper error handling
5c55164 
- identify.rs: Handle empty listen_addrs with if-let instead of unwrap()
- spawn.rs: Propagate directory creation errors with ? operator
- app.rs: Handle JSON encoding errors gracefully with logging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ancazamfir ancazamfir Awaiting requested review from ancazamfir ancazamfir is a code owner

@romac romac Awaiting requested review from romac romac is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

code: TODOs and FIXMES

1 participant

@doocho