fix: handle server side default for security token #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evfurman
approved these changes
Dec 18, 2025
seanl-circle
pushed a commit
that referenced
this pull request
Dec 18, 2025
🤖 I have created a release *beep* *boop* --- ## [0.6.3](v0.6.2...v0.6.3) (2025-12-18) ### Bug Fixes * allow setting stream security token ([#49](#49)) ([9dd6b82](9dd6b82)) * handle server side default for security token ([#53](#53)) ([54a0086](54a0086)) ### Miscellaneous Chores * remove GitHubSecurityLab/actions-permissions/monitor ([#51](#51)) ([ec91722](ec91722)) * **stepsecurity:** update workflows to use custom hosted runners with built-in StepSecurity ([#48](#48)) ([c2577fb](c2577fb)) * treat security_token specially for empty / null ([#52](#52)) ([5645140](5645140)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that if you leave the value unset, the server will generate one for you.
We need to mark it computed to accept the value.
We should also allow the old behaviour of setting an emtpy string.
I ran the acceptance tests locally and they finally passed.