Refactor core connection check & swap liquidity #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It aims to: - avoid spawning a seperate thread for checking bitcoin core connection and bring it inside the main loop. - create a dedicated api `check_for_swap_liquidity` - improvise the interval logic for periodic checks in the main loop of maker server.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #423 +/- ##
==========================================
+ Coverage 70.06% 70.18% +0.11%
==========================================
Files 34 34
Lines 4263 4226 -37
==========================================
- Hits 2987 2966 -21
+ Misses 1276 1260 -16 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to:
check_for_swap_liquidityNote to Reviewers:
This PR is a smaller version of #390 which includes the necessary design refactorings.