Create modern-china.csl

[fguogufe2]

Adding the house style of the journal Modern China

CSL Styles Pull Request Template

You're about to create a pull request to the CSL styles repository.
If you haven't done so already, see https://github.com/citation-style-language/styles/blob/master/CONTRIBUTING.md for instructions on how to contribute, and https://github.com/citation-style-language/styles/blob/master/STYLE_REQUIREMENTS.md for the requirements a style must meet before acceptance.
In addition, please fill out the pull request template below.

Description

This contribution aims to fill the gap that no dedicated csl file for this journal exists in the repository. The style derives from the Chicago Style, 17th edition, but with critical revisions to meet the journal's requirements.

Checklist

• Check that you've added a link to the style you used as a template in the <info> block at the beginning of the file with rel="template".
• Check that you've added a link to the style guidelines with rel="documentation".
• Check that you've added yourself as the <author> of the style or <contributor> for a style update.
• Check that you've used the correct terms or labels instead of hardcoding into affixes (e.g., <text variable="page" prefix="pp. "/>).
• Check that you've not used <text value="... if not absolutely necessary.
• Check that you've not changed line 1 of the style.

[adam3smith]

@fguogufe2 could you please go to https://github.com/fguogufe2/styles/tree/master and click "sync fork" at the top right? Let us know when that's done.

[POBrien333]

Please use the "genre" variable here

[fguogufe2]

done

[POBrien333]

Please move the space of the suffix into the group above as a delimiter.
Please check the rest of your style for such issues.

[fguogufe2]

done

[github-actions]

😟 There are some issues with your submission.

2 tests failed

modern-china: may not have any unused macros

expected: []
     got: ["editor", "translator"]

(compared using ==)

modern-china: must not use sentence case for title and container-title variables

expected "title" not to match /^title|container-title$/
Diff:
@@ -1 +1 @@
-/^title|container-title$/
+"title"

Please check the test report for details.

[github-actions]

😟 There are some issues with your submission.

4 tests failed

modern-china: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[0, "Multiple errors encountered:\n249:14: FATAL: Opening and ending tag mismatch: else line 247 and...choose line 453 and if\n484:14: FATAL: Opening and ending tag mismatch: macro line 452 and choose"]].empty?` to be truthy, got false

modern-china: must define all macros that are called by <text/> and <key/> elements

expected `{"access"=>#<CSL::Style::Macro name="access" children=[1]>, "archive"=>#<CSL::Style::Macro name="arch...Macro name="title" children=[1]>, "translator"=>#<CSL::Style::Macro name="translator" children=[1]>}.has_key?("point-locators")` to be truthy, got false

modern-china: may not have any unused macros

expected: []
     got: ["editor", "translator"]

(compared using ==)

modern-china: must not use sentence case for title and container-title variables

expected "title" not to match /^title|container-title$/
Diff:
@@ -1 +1 @@
-/^title|container-title$/
+"title"

Please check the test report for details.

[github-actions]

😟 There are some issues with your submission.

2 tests failed

modern-china: may not have any unused macros

expected: []
     got: ["editor", "translator"]

(compared using ==)

modern-china: must not use sentence case for title and container-title variables

expected "title" not to match /^title|container-title$/
Diff:
@@ -1 +1 @@
-/^title|container-title$/
+"title"

Please check the test report for details.

[fguogufe2]

@fguogufe2 could you please go to https://github.com/fguogufe2/styles/tree/master and click "sync fork" at the top right? Let us know when that's done.

Done

[github-actions]

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

modern-china.csl (new)

(“CSL search by example,” 2012; Fenner et al., 2019)
(Galindo-Castañeda et al., 2025; Hancké, Rhodes, and Thatcher, 2007)
(Mares, 2001)

---

“CSL search by example” (2012). Citation Style Editor. Citation Style Language. 2012. https://editor.citationstyles.org/searchByExample/.
FENNER, MARTIN, MERCÈ CROSAS, JEFFREY S. GRETHE, DAVID KENNEDY, HENNING HERMJAKOB, PHILLIPPE ROCCA-SERRA, GUSTAVO DURAND, et al. (2019) “A data citation roadmap for scholarly data repositories.” Scientific Data 6 (April).
GALINDO-CASTAÑEDA, TANIA, ELENA KOST, ELENA GIULIANO, RAFAELA FEOLA CONZ, JOHAN SIX, and MARTIN HARTMANN (2025) “Locating the microbes along the maize root system under nitrogen limitation: a root phenotypic approach.” Edited by Hannah M. Schneider and Doris Vetterlein. Annals of Botany 136 (5–6): 1143–62.
HANCKÉ, BOB, MARTIN RHODES, and MARK THATCHER, eds. (2007) Beyond Varieties of Capitalism: Conflict, Contradictions, and Complementarities in the European Economy. Oxford: Oxford University Press.
MARES, ISABELA (2001) “Firms and the welfare state: when, why, and how does social policy matter to employers?” In Varieties of Capitalism: the Institutional Foundations of Comparative Advantage, edited by Peter A. Hall and David Soskice, 184–212. Oxford: Oxford University Press.