Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): resMan init race #3176

Merged

Conversation

tens0rfl0w
Copy link
Contributor

@tens0rfl0w tens0rfl0w commented Feb 20, 2025

Goal of this PR

This code path is affected by a potential race condition during server initialization, as commands may be executed before the resource context is fully initialized.

How is this PR achieving the goal

Early-out if we are not initialized, as there is no res cache to target yet.

This PR applies to the following area(s)

Server

Successfully tested on

Game builds: Not applicable

Platforms: Windows (Server)

Checklist

  • Code compiles and has been tested successfully.
  • Code explains itself well and/or is documented.
  • My commit message explains what the changes do and what they are for.
  • No extra compilation warnings are added by these changes.

Fixes issues

/

@github-actions github-actions bot added the triage Needs a preliminary assessment to determine the urgency and required action label Feb 20, 2025
@FabianTerhorst FabianTerhorst added ready-to-merge This PR is enqueued for merging and removed triage Needs a preliminary assessment to determine the urgency and required action labels Feb 20, 2025
@github-actions github-actions bot added the invalid Requires changes before it's considered valid and can be (re)triaged label Feb 20, 2025
@prikolium-cfx prikolium-cfx merged commit 7a14f93 into citizenfx:master Feb 21, 2025
4 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid Requires changes before it's considered valid and can be (re)triaged ready-to-merge This PR is enqueued for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants