volume for pip cache, keep volumes #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kowh-ai
approved these changes
Apr 30, 2024
EricSoroos
reviewed
Apr 30, 2024
| - /usr/lib/python3.10/site-packages | ||
| - /root/.vscode-server | ||
| - pip_cache:/root/.cache/pip | ||
| - site_packages:/usr/lib/python3.10/site-packages |
There was a problem hiding this comment.
Is this actually going to work?
This isn't going to be live at build time, so your install is going to go into the image. Presumably, this will initialize the volume with the contents of the directory when first run, but then if you rebuild the image, the site-packages are going to be out of date.
There was a problem hiding this comment.
The startup script re-installs everything so if you have an out of date volume locally and upgrade ckan versions it should only dowload and re-install once.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #138 not keeping the volumes on restart, add volume for pip cache to prevent repeated downloads