-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default table properties via configuration #9219
Labels
package:table
type:feature
This issue reports a feature request (an idea for a new functionality or a missing option).
Milestone
Comments
Related to #8502. |
We'll be checking whether we cannot cover all properties at once when working on #8502. However, alignment is a higher priority so if covering all props would increase the scope too much, we'll focus on alignment only. |
The proposed solution is being developed/tracked in the other issue – #8502 (comment). |
@pomek Looking good! |
pomek
added a commit
that referenced
this issue
Apr 29, 2021
Feature (table): Support for the default table properties. Read more about [the feature in the documentation](https://ckeditor.com/docs/ckeditor5/latest/features/table.html). Closes #8502. Closes #9219. Fix (engine): The conversion upcast `elementToAttribute()` and `attributeToAttribute()` functions should not call the `model.value()` callback if the element will not be converted. Closes #9536. MINOR BREAKING CHANGE (table): Clases `TableAlignmentCommand`, `TableBackgroundColorCommand`, `TableBorderColorCommand`, `TableBorderStyleCommand`, `TableBorderWidthCommand`, `TableHeightCommand`, `TablePropertyCommand`, `TableWidthCommand` requires the second argument called `defaultValue` which is the default value for the command. MINOR BREAKING CHANGE (table): The `TablePropertiesView` class requires additional property in the object as the second constructor argument (`options.defaultTableProperties`).
@pomek Thank you! The team is delighted about this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
package:table
type:feature
This issue reports a feature request (an idea for a new functionality or a missing option).
📝 Provide a description of the new feature
What is the expected behavior of the proposed feature?
e.g. How do we configure the default table styles? I want a 1px border with certain colors to be pre-filled.
Example:
Upon the user inserting a table, they should see:
History: To avoid confusion, this remakes #6363's original post as its topic changed and it was closed. The new topic at #6841 is speaking about something different than setting default (clearing the value vs setting
none
to negate?)If you'd like to see this feature implemented, add a 👍 reaction to this post.
The text was updated successfully, but these errors were encountered: