Support for default table properties (CSS: .ck-content)
#9555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niegowski
requested changes
Apr 28, 2021
packages/ckeditor5-table/src/tableproperties/tablepropertiesediting.js
Outdated
Show resolved
Hide resolved
packages/ckeditor5-table/src/tableproperties/tablepropertiesui.js
Outdated
Show resolved
Hide resolved
…` util, and marked it as the protected function.
Co-authored-by: Kuba Niegowski <[email protected]>
niegowski
reviewed
Apr 29, 2021
packages/ckeditor5-table/tests/tableproperties/tablepropertiesediting.js
Outdated
Show resolved
Hide resolved
niegowski
approved these changes
Apr 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Feature (table): Support for the default table properties. Read more about the feature in the documentation. Closes #8502. Closes #9219.
Fix (engine): The conversion upcast
elementToAttribute()andattributeToAttribute()functions should not call themodel.value()callback if the element will not be converted. Closes #9536.MINOR BREAKING CHANGE (table): Clases
TableAlignmentCommand,TableBackgroundColorCommand,TableBorderColorCommand,TableBorderStyleCommand,TableBorderWidthCommand,TableHeightCommand,TablePropertyCommand,TableWidthCommandrequires the second argument calleddefaultValuewhich is the default value for the command.MINOR BREAKING CHANGE (table): The
TablePropertiesViewclass requires additional property in the object as the second constructor argument (options.defaultTableProperties).Additional information
🧐