Skip to content

refactor: professionalize codebase#1

Merged
claygeo merged 1 commit intomainfrom
refactor/professionalize-codebase
Apr 2, 2026
Merged

refactor: professionalize codebase#1
claygeo merged 1 commit intomainfrom
refactor/professionalize-codebase

Conversation

@claygeo
Copy link
Copy Markdown
Owner

@claygeo claygeo commented Apr 2, 2026

Summary

  • Fix all 27 ESLint issues (1 error + 26 warnings) across client and server
  • Add Vite code splitting via manual chunks (614KB single bundle -> 4 chunks under 172KB each)
  • Zero lint errors, zero warnings, 69/69 tests passing, clean typecheck, clean build

Changes

  • Lint error fixed: Conditional hook call in AuthContext
  • Unused vars removed: 8 client + 7 server unused imports/variables
  • Hook deps: eslint-disable on intentional mount-only useEffects
  • Code splitting: react-vendor (162KB), charts (162KB), supabase (171KB), state (3.6KB), app (114KB)

Test plan

  • npm run lint — 0 errors, 0 warnings
  • npm run typecheck — clean
  • npm test — 69/69 passing
  • npm run build — all chunks under 172KB, no warnings

🤖 Generated with Claude Code

- Fix conditional hook call in AuthContext (rules-of-hooks error)
- Remove all unused imports and variables across client and server
- Add eslint-disable for intentional mount-only useEffects
- Fix react-refresh/only-export-components warnings in context files
- Add Vite manual chunks for code splitting (614KB -> 4 chunks under 172KB each)
@netlify
Copy link
Copy Markdown

netlify bot commented Apr 2, 2026

Deploy Preview for trading-sim-hl ready!

Name Link
🔨 Latest commit 2112f22
🔍 Latest deploy log https://app.netlify.com/projects/trading-sim-hl/deploys/69cdb8cdad225c0008ca89b1
😎 Deploy Preview https://deploy-preview-1--trading-sim-hl.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@claygeo claygeo merged commit 21acd55 into main Apr 2, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant